Skip to content

chore(LinearMap/Defs): misc minor clean-up - #43518

Closed
grunweg wants to merge 3 commits into
leanprover-community:masterfrom
grunweg:semilinearmap-cleanup
Closed

chore(LinearMap/Defs): misc minor clean-up#43518
grunweg wants to merge 3 commits into
leanprover-community:masterfrom
grunweg:semilinearmap-cleanup

Conversation

@grunweg

@grunweg grunweg commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

- rename now-misnamed lemmas
- rename coe_coe lemma which was already a bad name
- use ofClass instead of manual type ascription, a few times
@grunweg grunweg changed the title Semilinearmap cleanup chore(LinearMap/Defs): misc minor clean-up Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

PR summary b08917227c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ SemilinearMapClass.semilinearMap
+ _root_.SemilinearMap.ofClass
+ coe_ofClass
+ ofClass_eq_toLinearMap
+ ofClass_injective
+ toLinearMap_eq_ofClass
- semilinearMap

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.
No changes to weak technical debt.

Current commit b08917227c
Reference commit a4d9f2fdd2

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

✅ PR Title Formatted Correctly

The title of this PR has been updated to match our commit style conventions.
Thank you!

@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Sep 7, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

@grunweg grunweg closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant