fix: cslib breakage from the mathlib rwaSuggestion linter - #50
Open
Kha wants to merge 1 commit into
Open
Conversation
The `rwaSuggestion` tactic-analysis linter that arrived with the mathlib master merge emits a `Try this:` info on `Language.dfa_num_state_min`; `cslib` builds and tests with `--wfail --iofail`, so that info is a build failure. Applied the suggestion: `rw … at h1; assumption` becomes `rwa … at h1`. Same hunk as the one in #48, which has since gone CONFLICTING — `master` picked up upstream's own version of that PR's three `mathlib4` files, and `mathlib4` is green through lint without them.
Contributor
Build report for fix: cslib breakage from the mathlib
|
| Repo | Critical | Build | Test | Lint |
|---|---|---|---|---|
| cslib | ✅ in 5s | ✅ in 8s | ✅ in 3s |
Stayed red
| Repo | Critical | Build | Test | Lint |
|---|---|---|---|---|
| reference-manual | ✅ | ⏭️ | ⏭️ | ⏭️ |
| verso | 🟥 in 62s | ⏭️ | ⏭️ | |
| verso-slides | ⏭️ | ⏭️ | ⏭️ | |
| verso-web-components | ⏭️ | ⏭️ | ⏭️ |
Stayed green
| Repo | Critical | Build | Test | Lint |
|---|---|---|---|---|
| aesop | ✅ | ✅ in 7s | ✅ in 4s | ⏭️ |
| batteries | ✅ | ✅ in 4s | ✅ in 4s | ✅ in 2s |
| import-graph | ✅ | ✅ in 2s | ✅ in 4s | ⏭️ |
| lean4-cli | ✅ | ✅ in 1s | ✅ in 0s | ⏭️ |
| mathlib4 | ✅ | ✅ in 183s | ✅ in 42s | ✅ in 94s |
| plausible | ✅ | ✅ in 1s | ✅ in 2s | ⏭️ |
| ProofWidgets4 | ✅ | ✅ in 3s | ✅ in 1s | ⏭️ |
| quote4 | ✅ | ✅ in 2s | ✅ in 1s | ⏭️ |
| BibtexQuery | ✅ in 3s | ⏭️ | ⏭️ | |
| comparator | ✅ in 2s | ⏭️ | ⏭️ | |
| doc-gen4 | ✅ in 9s | ⏭️ | ⏭️ | |
| illuminate | ✅ in 3s | ✅ in 11s | ⏭️ | |
| lean4-unicode-basic | ✅ in 2s | ⏭️ | ⏭️ | |
| lean4export | ✅ in 0s | ✅ in 8s | ⏭️ | |
| LeanSearchClient | ✅ in 1s | ✅ in 0s | ⏭️ | |
| leansqlite | ✅ in 7s | ✅ in 19s | ⏭️ | |
| nerodia | ✅ in 2s | ✅ in 21s | ⏭️ | |
| repl | ✅ in 1s | ✅ in 59s | ⏭️ | |
| subverso | ✅ in 6s | ⏭️ | ⏭️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts
cslibto therwaSuggestiontactic-analysis linter that came in with themathlib master merge.
cslibbuilds and tests with--wfail --iofail, so thelinter's single
Try this:info inCslib/Computability/Languages/MyhillNerode.leanis a build failure:Applied the suggestion:
rw … at h1; assumptionbecomesrwa … at h1.Verified locally on
nightly-2026-09-06:lake build --wfail --iofail,lake test --wfail --iofailandlake lintall pass forcslib.This is the same one-line hunk as in #48, which has since become
CONFLICTING:its other three files are
mathlib4adaptations thatmasterhas meanwhileacquired from upstream (
mathlib4is green — build, test and lint — inrun 34027830326).
So #48 and #49 can be closed once this lands.
Not fixed here
verso— andreference-manual,verso-slides,verso-web-componentsskippedbehind it — remain red on the shared-
subverso-build-directory problem, sixth dayrunning.
.downstream/downstream/updater.pyredirects thesubversorequirementof
verso/test-projects/*to the one sharedsubverso/checkout, and the nestedelan run … lake buildprocesses thatVerso.Code.Externalspawns thenmaterialize and prune
subverso/.lake/buildwhile the outerversobuild readsoleans out of it:
That is not a source adaptation — 1106 of
verso's 1114 targets built — and thefix belongs in
.downstream/orrepos.toml, which this PR does not touch.reference-manualwas skipped by CI and has not been built againstnightly-2026-09-06by anyone, here or in CI.