Skip to content

fix(websearch): run .bat custom scripts via shell on Windows (#190) #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
innocarpe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(websearch): run .bat custom scripts via shell on Windows (#190) #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/core/src/tests/web-search-handler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,17 @@ test("WebSearch returns a configuration error when neither a script nor an LLM c
);
});

test("WebSearch executes a configured .bat script on Windows", { skip: process.platform !== "win32" }, async () => {
const workspace = createTempWorkspace();
const scriptPath = path.join(workspace, "web-search.bat");
fs.writeFileSync(scriptPath, "@echo off\r\necho query=%1\r\n", "utf8");

const result = await handleWebSearchTool({ query: "test" }, createContext(workspace, { webSearchTool: scriptPath }));

assert.equal(result.ok, true);
assert.match(result.output ?? "", /query=test/);
});

function createContext(
projectRoot: string,
options: {
Expand Down
4 changes: 4 additions & 0 deletions packages/core/src/tools/web-search-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ async function runWebSearchScript(
return new Promise((resolve) => {
const child = spawn(scriptPath, [query], {
cwd: context.projectRoot,
// Node.js v20+ removed the automatic cmd.exe routing for .bat/.cmd
// files on Windows, so custom webSearchTool scripts pointing at .bat
// files need an explicit shell. (#190)
shell: process.platform === "win32",
env: { ...process.env, ...configuredEnv },
stdio: ["ignore", "pipe", "pipe"],
});
Expand Down