fix(ui): recognize ctrl+enter as newline in prompt input (#169) - #276
Open
innocarpe wants to merge 1 commit into
Open
fix(ui): recognize ctrl+enter as newline in prompt input (#169)#276innocarpe wants to merge 1 commit into
innocarpe wants to merge 1 commit into
Conversation
Terminals with modifyOtherKeys enabled report Ctrl+Enter as ESC[13;5u / ESC[27;5;13~. Parse these as return+ctrl and let getPromptReturnKeyAction insert a newline instead of submitting. (cherry picked from commit f1806d508241a9e8519ed8f493ffc4be8b78c6a4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Enternow inserts a newline in the prompt input instead of submitting, matching Shift+Enter behavior.Why
Terminals with
modifyOtherKeysenabled reportCtrl+EnterasESC[13;5u/ESC[27;5;13~. These sequences were not recognized, soCtrl+Entereither did nothing or submitted the message depending on the terminal.Changes
packages/cli/src/ui/hooks/useTerminalInput.ts: recognize Ctrl+Enter sequences asreturn+ctrl.packages/cli/src/ui/views/PromptInput.tsx:getPromptReturnKeyActiontreatsctrlas newline; footer hint updated.packages/cli/src/tests/prompt-input-keys.test.ts: tests for the new sequences.Validation
npm run typecheck✅npm test— prompt input key tests pass ✅Closes #169