feat(settings): support configurable timeout and maxRetries (#13) - #280
Open
innocarpe wants to merge 1 commit into
Open
feat(settings): support configurable timeout and maxRetries (#13)#280innocarpe wants to merge 1 commit into
innocarpe wants to merge 1 commit into
Conversation
Read timeoutMs and maxRetries from settings.json (or DEEPCODE_TIMEOUT_MS / DEEPCODE_MAX_RETRIES env vars) and pass them to the OpenAI client so intermittent network failures retry with the SDK's built-in exponential backoff instead of requiring manual retries. (cherry picked from commit 7c5f792ed3eb123a0e03c5e95a43a90e7f665eb6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeoutMsandmaxRetriesinsettings.json(orDEEPCODE_TIMEOUT_MS/DEEPCODE_MAX_RETRIESenv vars), passed to the OpenAI client so intermittent network failures retry automatically with the SDK's built-in exponential backoff.Why
On flaky networks, long requests (200K+ tokens) intermittently failed with
Connection error/fetch failedand required manual retries. There was no way to configure a request timeout or retry policy.Changes
packages/core/src/settings.ts: parsetimeoutMs/maxRetries(settings + env) into the resolved settings.packages/core/src/common/openai-client.ts: passtimeoutandmaxRetriesto the OpenAI client; include them in the client cache key.packages/core/src/tests/settings-and-notify.test.ts: tests for settings and env precedence.Validation
npm run typecheck✅npm test— new settings tests pass ✅Closes #13