feat(settings): support enabledSkillsDefaultOff whitelist mode (#178) - #285
Open
innocarpe wants to merge 1 commit into
Open
feat(settings): support enabledSkillsDefaultOff whitelist mode (#178)#285innocarpe wants to merge 1 commit into
innocarpe wants to merge 1 commit into
Conversation
…eb#178) With enabledSkillsDefaultOff: true (or DEEPCODE_ENABLED_SKILLS_DEFAULT_OFF=1), only skills explicitly enabled with true are injected into the system prompt; everything else is off by default. This lets users opt into default skills instead of having them all on. (cherry picked from commit 7d4cdf16024bb138d99acf07c8dd4c28066934fd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabledSkillsDefaultOffsetting (orDEEPCODE_ENABLED_SKILLS_DEFAULT_OFFenv var) enables whitelist mode: only skills explicitly set totrueare injected into the system prompt; everything else is off by default.falseskills are excluded).Why
Issue #178: the built-in skills (e.g.
karpathy-guidelines) are always injected unless individually disabled. Users who want a minimal, opt-in system prompt had no way to flip the default. Whitelist mode gives them full control.Changes
packages/core/src/settings.ts: parseenabledSkillsDefaultOff(settings + env) into resolved settings.packages/core/src/prompt.ts:readDefaultSkillDocsexcludes a skill whendefaultOff ? enabledSkills[name] !== true : enabledSkills[name] === false;getDefaultSkillPromptthreads the flag through.packages/core/src/session.ts: passenabledSkillsDefaultOffwhen building the default skill prompt.prompt.test.ts(whitelist behavior),settings-and-notify.test.ts(resolution + env).Validation
npm run typecheck✅npm test— new tests pass ✅Closes #178