fix: bring the test suite back to the pass state on newer GLib - #361
Merged
Conversation
Collaborator
|
Adding some reviewers that recently "did stuff" to LGI |
|
For me the changes in this PR seem to work. Tested on Fedora 44 (beta) with lua 5.4.8. |
Collaborator
Aire-One
approved these changes
Apr 23, 2026
Contributor
Author
|
removed in-code comments according to @Aire-One review |
Aire-One
reviewed
Apr 23, 2026
Aire-One
approved these changes
Apr 23, 2026
Aire-One
left a comment
Aire-One
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the back and forth 😬
14 tasks
|
Are there plans of merging this soon? I'm paying attention to when this is released because awesomewm fails to run on newer versions of glib. Thanks to all the maintainers! 🙇♂️ |
Collaborator
Collaborator
|
The GitHub permission system confuses me... I thought @Aire-One already had write access. Now that should definitely be the case. |
Collaborator
|
Thank you, @psychon for the write access :) |
Collaborator
|
Thank you, @luau-project |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Aug 19, 2026
Minimal port of lua-lgi fix for new Glib PR: 297414 Reported by: Kan Sasaki <sasaki12@gmail.com> Obtained from: lgi-devs/lgi#361 Approved by: portmgr (build and runtime fix blanket)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to bring back LGI's test suite (
make check) to the pass state on newer GLib.I would like to invite @reinerh , @ildar , @ji-cerny to test the proposed changes.
OS under test
Note
I used only Lua 5.5.0 on my tests.