Feature/composite property fields - #1795
Open
kwahlin wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
title:search filter expands to 20 different fields, many of them irrelevant. Additionally only one of the fields (hasTitle) is indexed as a nested field.This PR narrows the search scope to the 9 fields that are actually relevant to title queries and ensures that all of them are indexed as nested fields. (The screenshot below still shows one non-nested query. This is only because the field is missing entirely from the local test dataset.)
The same principle of narrowing the search scope to relevant fields also applies to other filters such as
contributor:.See also: libris/lxl_api_tests#53