pfftools: fix subject truncation for non-ASCII message subjects - #166
Open
wf34 wants to merge 1 commit into
Open
pfftools: fix subject truncation for non-ASCII message subjects#166wf34 wants to merge 1 commit into
wf34 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did reproduce this when exporting a PST archive, containing MS Todo entires. Tasks with English titles did convert correctly, while titles in other languages have converted with the first letter cut away.
My understanding that this prefix cutting is due to MAPI subject-prefix control code removal, but affects non-ASCII languages.
The proposed change was tested to correct exporting of non-English titles, e.g., to not produce this: