Skip to content

chore(release): avoid persisted checkout credentials #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wibias wants to merge 3 commits into
base: dev
Choose a base branch
from
+16 −4
Open

chore(release): avoid persisted checkout credentials #1568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56f6d1c
Set persist-credentials to false in release workflow
Wibias Aug 12, 2026
060b4e5
fix(release): authenticate tag creation explicitly
Wibias Aug 12, 2026
1965ddd
test(release): pin authenticated tag creation
Wibias Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
with:
fetch-depth: 0
persist-credentials: false

- name: Verify dispatched SHA
env:
Expand Down Expand Up @@ -453,8 +454,10 @@ jobs:
"${render_args[@]}"

if [ -z "$existing_tag_sha" ]; then
git tag "$release_tag" "$GITHUB_SHA"
git push origin "refs/tags/${release_tag}"
gh api --method POST \
"repos/${GITHUB_REPOSITORY}/git/refs" \
-f ref="refs/tags/${release_tag}" \
-f sha="$GITHUB_SHA" >/dev/null
fi

gh release create "$release_tag" --target "$GITHUB_SHA" --title "$release_tag" \
Expand Down
13 changes: 11 additions & 2 deletions tests/ci-workflows.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,17 @@ describe("GitHub Actions hardening", () => {
}
expect(createStep).not.toContain("set +e\n pr_notes");
expect(createStep.indexOf("gh api")).toBeGreaterThan(-1);
expect(createStep.indexOf('git tag "$release_tag"')).toBeGreaterThan(-1);
expect(createStep.indexOf("gh api")).toBeLessThan(createStep.indexOf('git tag "$release_tag"'));
const tagRefApi = '"repos/${GITHUB_REPOSITORY}/git/refs"';
expect(createStep).toContain("gh api --method POST");
expect(createStep).toContain(tagRefApi);
expect(createStep).toContain('-f ref="refs/tags/${release_tag}"');
expect(createStep).toContain('-f sha="$GITHUB_SHA" >/dev/null');
expect(createStep).not.toContain('git tag "$release_tag"');
expect(createStep).not.toContain('git push origin "refs/tags/${release_tag}"');

// Release notes must be fully rendered before the remote tag is created.
expect(createStep.indexOf('"${render_args[@]}"'))
.toBeLessThan(createStep.indexOf(tagRefApi));
// The notes baseline must read the FULL tag set, not `--merged HEAD`: stable
// tags live on main's lineage, which the preview branch does not carry, and a
// trailing same-core preview must not hide the stable from the range
Expand Down
Loading