Skip to content

fix(cursor): expose Grok 4.6 xhigh Fast - #1615

Open
jbaehova wants to merge 1 commit into
lidge-jun:devfrom
jbaehova:agent/fix-cursor-grok-4-6-xhigh-fast
Open

fix(cursor): expose Grok 4.6 xhigh Fast#1615
jbaehova wants to merge 1 commit into
lidge-jun:devfrom
jbaehova:agent/fix-cursor-grok-4-6-xhigh-fast

Conversation

@jbaehova

@jbaehova jbaehova commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • expose Cursor Grok 4.6's observed low / medium / high / xhigh ladder for both regular and Fast picker rows
  • preserve Cursor's existing parameterized Fast wire contract: send base model grok-4.6 with separate effort=xhigh and fast=true requested_model parameters
  • cover live discovery identities, picker effort metadata, regular request ids, Fast request parameters, and localized Cursor documentation

This is the Cursor-only follow-up requested when #1591 was closed as superseded. The direct xAI catalog half has already landed in #1593; this PR does not modify src/providers/registry.ts or any xAI routing behavior.

Root cause

The Cursor Grok 4.6 fallback rows were added by mirroring Grok 4.5's three-tier ladder before Cursor exposed its final lineup. Cursor now advertises cursor-grok-4.6-xhigh and cursor-grok-4.6-xhigh-fast, but OpenCodex still capped both rows at high. That hid Extra High from the picker and clamped explicit xhigh requests.

Fast requests remain parameterized rather than sending the flattened discovery slug: grok-4.6 plus effort=xhigh and fast=true. The flattened cursor-grok-4.6-xhigh-fast id is availability evidence only.

Verification

  • Cursor CLI account lineup includes cursor-grok-4.6-xhigh and cursor-grok-4.6-xhigh-fast
  • live Cursor request grok-4.6[effort=xhigh,fast=true] completed successfully
  • focused Cursor and registry tests — 119 passed, 0 failed
  • repository CI test matrix reproduced locally with Bun 1.3.14 — all four general-test shards completed in fresh-process batches with 0 failures
  • storage-policy tests — 9 passed, 0 failed
  • api-usage tests — 16 passed, 0 failed
  • GUI tests — 790 passed, 0 failed
  • both CI TypeScript checks — passed
  • privacy scan, release-helper syntax build, and CLI help smoke — passed
  • docs build — 265 pages built successfully
  • git diff --check — passed

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed; this changes Cursor capability metadata and model selection only, with no credential or authentication behavior changes.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • New Features

    • Added support for Grok 4.6 and Grok 4.6 Fast alongside Grok 4.5 variants.
    • Added the xhigh reasoning tier for Grok 4.6.
    • Improved model discovery for regular and Fast variants, including expanded context details.
  • Documentation

    • Updated provider and model guides in English, Japanese, Korean, Russian, Simplified Chinese, and Traditional Chinese.
    • Documented Fast request behavior, reasoning tiers, and model availability identifiers.
  • Tests

    • Expanded coverage for Grok 4.6 discovery, reasoning levels, context limits, and Fast requests.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a71c3081-e873-4422-95d7-b648a3ca9046

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7ebfef57-e2a1-4471-b55b-110bf3ab6ea8

📥 Commits

Reviewing files that changed from the base of the PR and between 3982dae and efe7f44.

📒 Files selected for processing (17)
  • docs-site/src/content/docs/guides/codex-app-models.md
  • docs-site/src/content/docs/guides/providers.md
  • docs-site/src/content/docs/ja/guides/codex-app-models.md
  • docs-site/src/content/docs/ja/guides/providers.md
  • docs-site/src/content/docs/ko/guides/codex-app-models.md
  • docs-site/src/content/docs/ko/guides/providers.md
  • docs-site/src/content/docs/ru/guides/codex-app-models.md
  • docs-site/src/content/docs/ru/guides/providers.md
  • docs-site/src/content/docs/zh-cn/guides/codex-app-models.md
  • docs-site/src/content/docs/zh-cn/guides/providers.md
  • docs-site/src/content/docs/zh-tw/guides/codex-app-models.md
  • docs-site/src/content/docs/zh-tw/guides/providers.md
  • src/adapters/cursor/effort-map.ts
  • src/adapters/cursor/request-builder.ts
  • structure/04_transports-and-sidecars.md
  • tests/cursor-discovery.test.ts
  • tests/cursor-effort-suffix.test.ts

📝 Walkthrough

Walkthrough

Cursor support now includes Grok 4.6 regular and Fast models, the xhigh effort tier, version-specific Fast request parameters, expanded discovery handling, tests, and localized documentation.

Changes

Cursor Grok model support

Layer / File(s) Summary
Routing and effort mappings
src/adapters/cursor/effort-map.ts, src/adapters/cursor/request-builder.ts, structure/04_transports-and-sidecars.md
Grok 4.6 adds xhigh support. Fast requests use the matching base model with effort, fast=true, and requested_model. Discovery handles flattened variants for both Grok versions.
Discovery and effort validation
tests/cursor-discovery.test.ts, tests/cursor-effort-suffix.test.ts
Tests cover Grok 4.6 regular and Fast IDs, xhigh filtering, context-window inference, effort ladders, suffix mapping, and Fast parameter translation.
Catalog and provider documentation
docs-site/src/content/docs/guides/*, docs-site/src/content/docs/ja/guides/*, docs-site/src/content/docs/ko/guides/*, docs-site/src/content/docs/ru/guides/*, docs-site/src/content/docs/zh-cn/guides/*, docs-site/src/content/docs/zh-tw/guides/*
Localized documentation lists Grok 4.5/4.6 regular and Fast variants, effort tiers, Fast wire parameters, and discovery-only flattened IDs.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to efe7f

This localized change exposes Cursor Grok 4.6 xhigh options while preserving the existing Fast request contract; no actionable merge-blocking risk remains after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant CursorDiscovery
  participant CursorEffortMap
  participant CursorRequestBuilder
  Client->>CursorDiscovery: discover Grok 4.6 variants
  CursorDiscovery->>CursorEffortMap: map effort suffixes
  CursorEffortMap-->>CursorDiscovery: return supported effort tiers
  Client->>CursorRequestBuilder: select Grok 4.6 Fast
  CursorRequestBuilder->>CursorRequestBuilder: set base model, effort, fast=true, requested_model
Loading

Possibly related PRs

  • lidge-jun/opencodex#1591: Updates the same Cursor Grok 4.6 effort mappings, request parameters, discovery behavior, documentation, and tests.
  • lidge-jun/opencodex#1547: Shares Cursor Grok 4.6 routing, effort mapping, discovery, and test coverage.
  • lidge-jun/opencodex#1228: Overlaps in Cursor effort mapping, Fast request handling, and related discovery tests.

Suggested reviewers: ingwannu, lidge-jun, wibias

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: exposing Grok 4.6 xhigh Fast support in Cursor.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

✅ READY

  • all PR quality gates passed; the review readiness checklist is complete.

Review readiness checklist

  • ✅ All CI tests are green on my local testing.
  • ✅ I pushed my PR to the latest dev commit.
  • ✅ I resolved all correct Codex and CodeRabbit findings.
  • ✅ My PR is ready for review.

4/4 boxes ticked.

This pull request is already Ready for Review.
The review-ready label marks this PR as ready; review automation runs independently. If no CodeRabbit review appears, comment @coderabbitai review to request one.
Maintainers: @lidge-jun @Ingwannu @Wibias

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Tip

For best results, initiate chat on the files or code changes.

@github-actions[bot] PR #1615 is marked ready for review at efe7f440923f38100fda02db58d6605ef418e204.

I am replying to the latest status only. Earlier comment context is unavailable.


🧠 Learnings used
Learnt from: Wibias
Repo: lidge-jun/opencodex PR: 986
File: .github/workflows/enforce-pr-target.yml:631-636
Timestamp: 2026-08-04T06:41:30.089Z
Learning: For the PR readiness gate in `.github/workflows/enforce-pr-target.yml`, the required scope is to bind contributor checklist completion and maintainer notification to the exact PR head SHA, then reset them after a new head commit. Maintainer approval staleness is separate from this gate and should be enforced by GitHub branch protection, such as `dismiss-stale-reviews` or `require_last_push_approval`, when configured for `dev`.

You are interacting with an AI system.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@github-actions[bot] The readiness checklist is complete. I will review pull request #1615 at efe7f440923f38100fda02db58d6605ef418e204.


🧠 Learnings used
Learnt from: Wibias
Repo: lidge-jun/opencodex PR: 986
File: .github/workflows/enforce-pr-target.yml:631-636
Timestamp: 2026-08-04T06:41:30.089Z
Learning: For the PR readiness gate in `.github/workflows/enforce-pr-target.yml`, the required scope is to bind contributor checklist completion and maintainer notification to the exact PR head SHA, then reset them after a new head commit. Maintainer approval staleness is separate from this gate and should be enforced by GitHub branch protection, such as `dismiss-stale-reviews` or `require_last_push_approval`, when configured for `dev`.
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Wibias

Wibias commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Thanks for following up with this Cursor-only version. This addresses the main concern I had on #1578: the Fast xhigh behavior now has both live evidence and a regression that pins the actual wire contract (grok-4.6 + effort=xhigh + fast=true) instead of relying on the flattened discovery slug.

The scope also looks right now: Grok 4.5 stays capped at high, only Cursor Grok 4.6 gains xhigh, and the already-landed xAI work remains separate.

I don’t see a code blocker here. Please rebase onto latest dev and let the repository CI actually run on the rebased head. One small non-blocking improvement would be to add an explicit no-effort assertion for both regular and Fast Grok 4.6, so the fallback/default behavior stays intentional if the ladder changes again.

After rebase + green CI, this looks good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working review-ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants