Skip to content

docs(devlog): record the real workflow state at the gated SHA - #1999

Merged
lidge-jun merged 1 commit into
devfrom
codex/cursor-call-release-note-2
Aug 18, 2026
Merged

docs(devlog): record the real workflow state at the gated SHA#1999
lidge-jun merged 1 commit into
devfrom
codex/cursor-call-release-note-2

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-up to #1996. The readiness note said publishing waits on Cross-platform CI and Service lifecycle at the release SHA, but never answered whether either exists for this one. Measured both and recorded the answer.

  • Cross-platform CI: run 32104616258, started automatically on the merge, still in_progress.
  • Service lifecycle: never ran at this SHA — and that is correct rather than a gap. It triggers only on src/service.ts, src/cli.ts, src/cli/index.ts, src/lib/bun-runtime.ts, package.json, bun.lock, or its own workflow file (.github/workflows/service-lifecycle.yml:6-16), and this campaign touched none of them. It will fire on the release commit, because a release always bumps package.json.

The distinction matters for anyone reading the note later: its absence means the campaign did not touch service-lifecycle surface, not that a gate was skipped. The real outstanding precondition is the CI run — and that is precisely the one the owner's merge-time waiver does not extend to, since release.ts:393-401 blocks on it regardless.

Also records that dev advanced to aad8e2601 when #1996 merged, and that the commit adds exactly one file, so the gate evidence still describes the code on dev.

Verification

Docs-only. Facts in the note were measured, not assumed:

gh run list --commit 4f72d6f755 --json name,status,conclusion
  -> [{"name":"Cross-platform CI","status":"in_progress"}]
gh run list --workflow 'Service lifecycle' ... select(.headSha=="4f72d6f755")
  -> (empty)
git diff --name-only f7c9e2749 aad8e2601 | grep -E '<service-lifecycle trigger paths>'
  -> no matches

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (This PR is that update.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (Docs only.)

Summary by CodeRabbit

  • Documentation
    • Updated release-readiness guidance with the latest gated-merge progress.
    • Clarified that cross-platform validation remains in progress and its evidence is still pending.
    • Documented that service lifecycle validation will run with the release commit after the package version update.
    • Refined promotion prerequisites, including CI verification, version confirmation, and adherence to the approved release process.

The note claimed publishing needs Cross-platform CI and Service lifecycle at the
release SHA but never said whether either exists for this one. Measured both.

Cross-platform CI is run 32104616258, started automatically on the merge and still
in_progress. Service lifecycle never ran — and that is correct, not a gap. It
triggers only on src/service.ts, src/cli.ts, src/cli/index.ts, src/lib/bun-runtime.ts,
package.json, bun.lock or its own workflow file, and this campaign touched none of
them (verified with git diff --name-only across the merge range). It will fire on the
release commit, because a release always bumps package.json, which is a trigger path.

So the distinction worth stating: its absence means the campaign did not touch
service-lifecycle surface, not that a gate was skipped. The real outstanding
precondition is the CI run, and that is the one the owner's merge-time waiver does
not extend to — release.ts blocks on it regardless of what a human waived earlier.

Also notes that dev advanced to aad8e26 when the note itself merged, and that the
commit adds one file, so the gate evidence still describes the code on dev.
@lidge-jun
lidge-jun merged commit 314f3ed into dev Aug 18, 2026
6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3f27a484-ba09-4ef8-9983-dc12e28f2b22

📥 Commits

Reviewing files that changed from the base of the PR and between aad8e26 and 737ae8c.

📒 Files selected for processing (1)
  • devlog/_plan/260818_cursor_call_integration/060_release_readiness.md

📝 Walkthrough

Walkthrough

The release-readiness note records the post-merge dev state, current workflow status, Service lifecycle timing, pending platform evidence, and revised promotion prerequisites.

Changes

Release readiness

Layer / File(s) Summary
Workflow evidence and promotion prerequisites
devlog/_plan/260818_cursor_call_integration/060_release_readiness.md
The note records the post-merge dev commit. It marks Cross-platform CI as in progress and Service lifecycle as correctly untriggered. Promotion now requires CI verification and defers Service lifecycle until the release commit updates package.json.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: ingwannu, wibias

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cursor-call-release-note-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun
lidge-jun deleted the codex/cursor-call-release-note-2 branch August 18, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant