docs(devlog): record the real workflow state at the gated SHA - #1999
Merged
Conversation
The note claimed publishing needs Cross-platform CI and Service lifecycle at the release SHA but never said whether either exists for this one. Measured both. Cross-platform CI is run 32104616258, started automatically on the merge and still in_progress. Service lifecycle never ran — and that is correct, not a gap. It triggers only on src/service.ts, src/cli.ts, src/cli/index.ts, src/lib/bun-runtime.ts, package.json, bun.lock or its own workflow file, and this campaign touched none of them (verified with git diff --name-only across the merge range). It will fire on the release commit, because a release always bumps package.json, which is a trigger path. So the distinction worth stating: its absence means the campaign did not touch service-lifecycle surface, not that a gate was skipped. The real outstanding precondition is the CI run, and that is the one the owner's merge-time waiver does not extend to — release.ts blocks on it regardless of what a human waived earlier. Also notes that dev advanced to aad8e26 when the note itself merged, and that the commit adds one file, so the gate evidence still describes the code on dev.
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release-readiness note records the post-merge ChangesRelease readiness
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1996. The readiness note said publishing waits on Cross-platform CI and Service lifecycle at the release SHA, but never answered whether either exists for this one. Measured both and recorded the answer.
32104616258, started automatically on the merge, stillin_progress.src/service.ts,src/cli.ts,src/cli/index.ts,src/lib/bun-runtime.ts,package.json,bun.lock, or its own workflow file (.github/workflows/service-lifecycle.yml:6-16), and this campaign touched none of them. It will fire on the release commit, because a release always bumpspackage.json.The distinction matters for anyone reading the note later: its absence means the campaign did not touch service-lifecycle surface, not that a gate was skipped. The real outstanding precondition is the CI run — and that is precisely the one the owner's merge-time waiver does not extend to, since
release.ts:393-401blocks on it regardless.Also records that
devadvanced toaad8e2601when #1996 merged, and that the commit adds exactly one file, so the gate evidence still describes the code ondev.Verification
Docs-only. Facts in the note were measured, not assumed:
Checklist
Summary by CodeRabbit