fix(commandcode): share reasoning-facts table and fix GLM slug decode (lands #1800) - #2015
Merged
Conversation
…ng for API-key preset The `commandcode` (API-key) registry entry was missing the official model-profile reasoning-facts table that the OAuth `command-code` entry carries. Two symptoms followed: 1. The Codex catalog advertised no reasoning levels for API-key models (deepseek-v4-flash/pro, GLM-5.x), so clients forced effort none and requests failed with 400 'messages.content.type is invalid'. 2. The router's known-ids decode source missed the native slash ids, so Codex-facing slugs like `commandcode/deepseek-deepseek-v4-pro` were forwarded upstream verbatim and rejected with 400 'unsupported_model'. Also fix the GLM table keys to match the exact upstream ids (`zai-org/GLM-5.3` not `zai-org/glm-5.3`) and make the effort lookup case-insensitive, and add GLM-5 / 5.1 / 5.2-Fast (verified high/max from their official profiles).
# Conflicts: # tests/slug-codec.test.ts
Merged
4 tasks
Contributor
|
✅ Deterministic PR hygiene checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands contributor PR #1800 (youngchangjo) on current
dev: thecommandcodeAPI-key registry entry shares the official reasoning-facts table with the OAuthcommand-codeentry, and GLM slugs decode with their canonical casing (zai-org/GLM-5.3). The original PR had one test-file conflict against today's slug-codec additions; resolved additively (both test blocks kept).Verification
tsc --noEmitcleanChecklist