fix(cursor): pin session id and continue external tool results as userMessageAction (lands #1990)

[lidge-jun]

Summary

Lands contributor PR #1990 (laerad777) on current dev: the cursor live transport pins one stable session id per logical conversation (was randomUUID() per request, so server-side thread reuse never engaged), and external tool results continue as userMessageAction. The one test conflict against #1997's assistant-role assertions is composed (both assertions kept).

Verification

• cursor live-transport + adapter + blob + hardening + transport-retry suites: 147/0
• tsc --noEmit clean

Checklist

• Original PR's regression tests included
• Typecheck green
• No GUI change (no screenshot required)

Summary by CodeRabbit

• Bug Fixes

  • Improved Cursor conversation continuity across retries and transport reconnects.
  • Preserved tool-result history when external models continue a conversation.
  • Improved cleanup and execution context handling for live sessions.
  • Normalized blank session identifiers to prevent connection issues.

• Tests

  • Added coverage for session continuity, external tool-result continuations, and live transport behavior.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d992269c-de69-4c01-ac79-6b0cd6b9bca2

📥 Commits

Reviewing files that changed from the base of the PR and between 891c828 and c6b8d7e.

📒 Files selected for processing (8)

• src/adapters/cursor.ts
• src/adapters/cursor/live-transport.ts
• src/adapters/cursor/protobuf-request.ts
• src/adapters/cursor/transport.ts
• tests/cursor-adapter.test.ts
• tests/cursor-blob.test.ts
• tests/cursor-hardening.test.ts
• tests/cursor-live-transport.test.ts

---

📝 Walkthrough

Walkthrough

Cursor now preserves conversation IDs across transport rebuilds, separates Connect session IDs from shell ownership IDs, and sends explicit continuation text for external-model tool-result replays. Tests cover session propagation, header transmission, ownership isolation, and continuation history.

Changes

Cursor session continuity

Layer / File(s)	Summary
Session identity and shell ownership src/adapters/cursor.ts, src/adapters/cursor/transport.ts, src/adapters/cursor/live-transport.ts, tests/cursor-adapter.test.ts, tests/cursor-hardening.test.ts, tests/cursor-live-transport.test.ts	Cursor turn retries pass the conversation ID as sessionId. Transports preserve trimmed injected IDs and use a separate shellOwnerId for native execution contexts and shell cleanup. Tests verify transport IDs, Connect headers, isolated helper sessions, and blank-ID normalization.
External-model tool-result continuations src/adapters/cursor/protobuf-request.ts, tests/cursor-blob.test.ts	External models use userMessageAction with the configured continuation text after tool results. Native models retain resumeAction. Token estimation uses the selected action text, and replay tests verify tool-result history retention.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CursorTurn
  participant CursorTransportFactory
  participant LiveCursorTransport
  participant NativeExecution
  CursorTurn->>CursorTransportFactory: pass conversation ID as sessionId
  CursorTransportFactory->>LiveCursorTransport: create transport with sessionId
  LiveCursorTransport->>NativeExecution: use shellOwnerId for execution context
  LiveCursorTransport->>NativeExecution: clean up shells by shellOwnerId

Loading

sequenceDiagram
  participant CursorRequest
  participant ProtobufRequest
  participant ExternalModel
  CursorRequest->>ProtobufRequest: provide tool-result history
  ProtobufRequest->>ProtobufRequest: select continuation text
  ProtobufRequest->>ExternalModel: send userMessageAction with continuation text

Loading

Possibly related PRs

• lidge-jun/opencodex#318: Modifies Cursor external-model tool-result continuations and session/conversation ID handling.
• lidge-jun/opencodex#366: Modifies Cursor session continuity and external tool-result continuation behavior.
• lidge-jun/opencodex#1915: Modifies Cursor session ID propagation and reuse across turns.

Suggested reviewers: ingwannu, wibias

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/land-1990

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}