fix(responses): flatten the Codex 0.147 functions namespace in the parser (lands #1896 subset) - #2020
Merged
Conversation
Codex 0.147 groups its ordinary client tools under the reserved `functions` namespace, including freeform custom tools such as code-mode `exec`. Flatten those children as top-level tools (no namespace) and lower nested custom tools the same way as top-level ones; other namespace groups keep MCP-style round-trip routing. Extracted from PR #1896 (credit: original author of #1896). The code-mode rejection-guidance changes with hardcoded exec / mcp_opencodex-responses_* name lists were intentionally dropped; a catalog-helper approach will follow separately.
7 tasks
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe parser centralizes freeform custom-tool conversion, adds ChangesResponses tool normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands the load-bearing subset of contributor PR #1896: namespace groups named
functions(Codex 0.147's reserved grouping) flatten their children as top-level tools — including nestedcustomfreeform tools like code-modeexec— while other namespaces keep MCP-style round-trip routing. The hardcoded exec/mcp_* name lists from the original are deliberately dropped pending a catalog-helper approach.Verification
tsc --noEmitcleanChecklist
Summary by CodeRabbit
New Features
Bug Fixes