Skip to content

Expose web search sidecar enabled status - #2030

Closed
louis-tepe wants to merge 12 commits into
lidge-jun:devfrom
louis-tepe:upstream/web-search-status-enabled
Closed

Expose web search sidecar enabled status#2030
louis-tepe wants to merge 12 commits into
lidge-jun:devfrom
louis-tepe:upstream/web-search-status-enabled

Conversation

@louis-tepe

@louis-tepe louis-tepe commented Aug 18, 2026

Copy link
Copy Markdown

Summary

  • expose the effective webSearchSidecar.enabled value in GET sidecar settings
  • preserve and return that state after partial PUT updates
  • add focused coverage for default-enabled and explicitly-disabled configurations

Validation

  • bun test tests/sidecar-settings-vision-controls.test.ts (8 pass)
  • bun run typecheck
  • git diff --check

This only changes management status serialization; provider routing and OpenAI passthrough are untouched.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • Enhancements

    • Sidecar settings now report whether web search is enabled.
    • Web search is enabled by default unless explicitly disabled.
    • Updating other web search settings preserves the selected enabled or disabled state.
  • Tests

    • Added coverage for default, disabled, and preserved web search states.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • wrong branch ancestry; rebase onto the latest dev. hygiene: unsponsored_surface.

What to do

  • Rebase onto the current dev branch instead of opening from main.
  • Fix unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: package.json.
  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ All CI tests are green on my local testing.
  • ⬜ I pushed my PR to the latest dev commit.
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.
@louis-tepe Tick the boxes once your local CI is green, your branch is on the latest dev commit, and every correct Codex and CodeRabbit finding is resolved.

@github-actions github-actions Bot changed the title Expose web search sidecar enabled status [WRONG BRANCH] Expose web search sidecar enabled status Aug 18, 2026
@github-actions
github-actions Bot marked this pull request as draft August 18, 2026 12:40
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7451acaf-e072-492d-aa37-64402c6e32d4

📥 Commits

Reviewing files that changed from the base of the PR and between e97fb26 and 6cb5598.

📒 Files selected for processing (2)
  • src/server/management/config-routes.ts
  • tests/sidecar-settings-vision-controls.test.ts

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The sidecar settings GET and PUT responses now include the effective web-search enabled state. The state defaults to enabled and remains disabled when explicitly configured, including after unrelated settings updates.

Changes

Sidecar web-search state

Layer / File(s) Summary
Expose and validate effective web-search state
src/server/management/config-routes.ts, tests/sidecar-settings-vision-controls.test.ts
GET and PUT /api/sidecar-settings responses now include webSearch.enabled, which defaults to true unless explicitly disabled. Tests cover the default state, configured disabled state, and preservation after updating streamRoutedModelOutput.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6cb55

The PR exposes and preserves the web search sidecar enabled state in management settings without changing provider routing; no actionable merge-blocking risk remains after normal checks.

Suggested reviewers: ingwannu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes exposing the effective web-search sidecar enabled status, which is the main change.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@louis-tepe
louis-tepe changed the base branch from main to dev August 18, 2026 12:41
@github-actions github-actions Bot changed the title [WRONG BRANCH] Expose web search sidecar enabled status Expose web search sidecar enabled status Aug 18, 2026
@louis-tepe

Copy link
Copy Markdown
Author

Superseded by #2033, rebased on the required dev target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants