Expose web search sidecar enabled status - #2030
Conversation
Promote dev to main: Wave 5 campaign (107 commits)
Promote dev to main: CodeQL lidge-jun#87 ReDoS fix + closeout correction
Promote dev to main: Wave 5 record corrections
Promote dev to main: alert-precision record
Promote dev to main: post-scan closing note
Promote dev to main: final Wave 5 errata
Promote dev to main: Wave 5 closing record
[WRONG BRANCH] Promote dev to main: v2.25.0 release
release: v2.25.0
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe sidecar settings GET and PUT responses now include the effective web-search enabled state. The state defaults to enabled and remains disabled when explicitly configured, including after unrelated settings updates. ChangesSidecar web-search state
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR exposes and preserves the web search sidecar enabled state in management settings without changing provider routing; no actionable merge-blocking risk remains after normal checks. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #2033, rebased on the required |
Summary
webSearchSidecar.enabledvalue in GET sidecar settingsValidation
bun test tests/sidecar-settings-vision-controls.test.ts(8 pass)bun run typecheckgit diff --checkThis only changes management status serialization; provider routing and OpenAI passthrough are untouched.
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit
Enhancements
Tests