Skip to content

fix(mimo): route Pro images through vision sidecar - #2031

Open
Ingwannu wants to merge 1 commit into
devfrom
ingw/fix-mimo-vision-1927
Open

fix(mimo): route Pro images through vision sidecar#2031
Ingwannu wants to merge 1 commit into
devfrom
ingw/fix-mimo-vision-1927

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • classify only the canonical Xiaomi token-plan mimo-v2.5-pro route as text-only so image requests use the configured vision sidecar
  • keep mimo-v2.5 on its verified native image-input path
  • preserve custom-destination isolation so a hand-rolled provider named mimo does not inherit the registry capability claim
  • record the provider-scoped modality decision in the catalog architecture notes

Closes #1927.

Verification

  • bun test tests/provider-registry-parity.test.ts tests/catalog-vision-sidecar-modalities.test.ts — 50 pass
  • bun run typecheck — clean
  • bun run privacy:scan — passed
  • git diff --check — clean

The current dev stabilization work is separate; this PR's focused suites are green on exact head and full cross-platform CI must pass before merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or architecture notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

No separate Go-native counterpart exists for this TypeScript provider catalog/vision-sidecar metadata path.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected image-input handling for Xiaomi MiMo models.
    • mimo-v2.5-pro now uses the vision sidecar when needed, while mimo-v2.5 retains native image support.
    • Custom MiMo destinations remain unaffected.
  • Documentation

    • Added documentation clarifying modality support and routing behavior.
  • Tests

    • Added coverage to verify model capability and custom-destination behavior.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 82f81392-21ae-4916-bbc7-073813915fb4

📥 Commits

Reviewing files that changed from the base of the PR and between aaf0469 and dc0334e.

📒 Files selected for processing (4)
  • src/providers/registry.ts
  • structure/03_catalog-and-subagents.md
  • tests/catalog-vision-sidecar-modalities.test.ts
  • tests/provider-registry-parity.test.ts

Included review availability: Your plan includes up to 10 reviews per rolling hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The built-in MiMo provider now routes images for mimo-v2.5-pro through the vision sidecar while keeping native image input for mimo-v2.5. Tests cover modality enrichment, registry parity, and custom destination isolation.

Changes

MiMo vision routing

Layer / File(s) Summary
Registry classification and decision record
src/providers/registry.ts, structure/03_catalog-and-subagents.md
At lines 2473–2476, the canonical MiMo provider adds mimo-v2.5-pro to noVisionModels. Lines 258–272 document that mimo-v2.5 remains natively vision-capable and custom destinations are unaffected.
Modality and parity validation
tests/catalog-vision-sidecar-modalities.test.ts, tests/provider-registry-parity.test.ts
Lines 49–73 verify modality enrichment and custom-destination isolation. Lines 70–71 verify that only mimo-v2.5-pro appears in the provider classification.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to dc033

The change narrowly routes the canonical Pro image path through the configured vision sidecar while preserving the verified native path and custom-provider isolation; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: lidge-jun

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes routing MiMo Pro image requests through the vision sidecar, which is the primary change.
Linked Issues check ✅ Passed The registry, documentation, and tests implement all requirements from issue #1927, including Pro sidecar routing, native support for v2.5, and custom-provider isolation.
Out of Scope Changes check ✅ Passed All changes support issue #1927: registry configuration, decision-log documentation, and focused regression coverage are directly related.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ingw/fix-mimo-vision-1927

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant