-
Notifications
You must be signed in to change notification settings - Fork 852
docs(devlog): close the release audit with the merged fixes and the verified dev state #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,3 +161,34 @@ this range. Recorded so it is not rediscovered as new, but it is not this releas | |
| Full suite at the tip carrying both: **13717 pass / 15 skip / 0 fail** across 866 files; | ||
| typecheck exit 0; privacy scan passed. All on `ssh lidge`. | ||
|
|
||
|
|
||
| ## Closeout — the fixes are on dev | ||
|
|
||
| All four landed in dependency order. The order was forced, not chosen: `privacy:scan` runs in | ||
| the `gates` job, so while `dev` itself was failing it, every branch cut from `dev` inherited | ||
| the failure. #2173 was red for exactly that reason and went green once #2175 landed. | ||
|
|
||
| | PR | dev merge commit | What it fixes | | ||
| |---|---|---| | ||
| | #2175 | `5bcc91d0e` | the broken `privacy:scan` gate on `dev` itself | | ||
| | #2170 | `9eb6647d5` | caller-controlled marker reaching `usage.jsonl` and `/api/logs` | | ||
| | #2173 | `b2878f8e8` | `tool_search_call` / `custom_tool_call` id namespace | | ||
| | #2174 | `12c14d5c3` | this audit record | | ||
|
|
||
| Verified at the `dev` tip on `ssh lidge`: | ||
|
|
||
| - `bun run test` — **13719 pass / 15 skip / 0 fail** across 866 files. | ||
| - `bun x tsc --noEmit` — exit 0. | ||
| - `bun run privacy:scan` — passed. It **failed** on `dev` before #2175, which is the whole | ||
| reason that PR exists. | ||
| - GitHub CI run `32334852749` — completed **success** at `b2878f8e8`, the commit carrying both | ||
| code fixes. `12c14d5c3` above it is docs-only. | ||
|
Comment on lines
+178
to
+185
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git diff --name-status b2878f8e8 12c14d5c3
rg -n -C 2 '13717|13719|bun run test|b2878f8e8|12c14d5c3' \
devlog/_plan/260820_bug_pr_backlog_consolidation/100_release_audit.mdRepository: lidge-jun/opencodex Length of output: 1374 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- commit topology ---'
git show -s --format='%H%n%P%n%s' b2878f8e8
git show -s --format='%H%n%P%n%s' 12c14d5c3
git rev-parse dev
printf '%s\n' '--- changes in the docs commit ---'
git diff --stat 12c14d5c3^ 12c14d5c3
git diff --name-status 12c14d5c3^ 12c14d5c3
printf '%s\n' '--- audit context ---'
sed -n '150,195p' devlog/_plan/260820_bug_pr_backlog_consolidation/100_release_audit.md
printf '%s\n' '--- test inventory at the two commits ---'
for rev in b2878f8e8 12c14d5c3; do
printf '%s: ' "$rev"
git ls-tree -r --name-only "$rev" -- tests 2>/dev/null | wc -l
git ls-tree -r --name-only "$rev" -- '*.test.*' '*.spec.*' 2>/dev/null | wc -l
doneRepository: lidge-jun/opencodex Length of output: 3091 🏁 Script executed: #!/bin/bash
set -euo pipefail
printf '%s\n' '--- test scripts and configuration ---'
rg -n -C 3 '"test"|bun run test|bun test|testCommand|include|exclude|skip' \
package.json bunfig.toml vitest.config.* vite.config.* 2>/dev/null || true
printf '%s\n' '--- tracked-tree comparison excluding the audit file ---'
if git diff --quiet b2878f8e8 12c14d5c3 -- ':!devlog/_plan/260820_bug_pr_backlog_consolidation/100_release_audit.md'; then
echo 'No tracked changes outside the audit file.'
else
git diff --stat b2878f8e8 12c14d5c3 -- ':!devlog/_plan/260820_bug_pr_backlog_consolidation/100_release_audit.md'
fi
printf '%s\n' '--- test-related file lists ---'
for rev in b2878f8e8 12c14d5c3; do
echo "[$rev]"
git ls-tree -r --name-only "$rev" | rg '(^|/)([^/]+\.)?(test|spec)\.[^/]+$' | wc -l
done
printf '%s\n' '--- dynamic/environment-sensitive test references ---'
rg -n -S 'process\.env|Bun\.env|Date\.now|new Date|Math\.random|readdir|glob|GITHUB|CI|SSH|network|fetch\(' \
--glob '*.{test,spec}.{ts,tsx,js,jsx,cjs,mjs}' tests 2>/dev/null | head -200 || trueRepository: lidge-jun/opencodex Length of output: 21418 Document the run conditions for both full-suite results.
🤖 Prompt for AI Agents |
||
| - Fixes present in `dev` source, not just in a merge commit: `shadowSourceModelPrefix` ×1, | ||
| `tool_search_call` ×3. | ||
|
|
||
| The three findings under "Deliberately left" are unchanged and still open questions. Nothing in | ||
| this closeout resolves them; they need a product decision, not a patch. | ||
|
|
||
| Release execution remains unauthorized: no `scripts/release.ts`, no publish, no tag, no change | ||
| to `main` or `preview`. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_finAdding this closeout records a terminal outcome: the fixes landed, verification passed, and the residual questions received an explicit
NEEDS_HUMAN-style disposition. Leaving the unit indevlog/_plan/therefore falsely presents completed work as active; move the entire260820_bug_pr_backlog_consolidationdirectory todevlog/_fin/as part of the closeout.AGENTS.md reference: AGENTS.md:L75-L78
Useful? React with 👍 / 👎.