-
Notifications
You must be signed in to change notification settings - Fork 853
fix(ci): stop the Windows leg from truncating and mismeasuring its own shards #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -553,7 +553,16 @@ jobs: | |
| # Sharded like the Linux legs. The single-leg run reached 30 minutes on a | ||
| # green suite and was killed in cleanup; four shards put each leg inside the | ||
| # same budget the Linux shards already hold. | ||
| timeout-minutes: 15 | ||
| # | ||
| # 15 was that Linux budget, and on this leg it truncated the evidence rather | ||
| # than bounding a hang: shard 1/4 of run 32340498394 was CANCELLED at exactly | ||
| # 15m12s while still executing tests, so its result was neither pass nor fail | ||
| # and the composed-acceptance cases it carries could not be read at all. The | ||
| # other shards finished in 14-15 minutes, which is the wrong side of the | ||
| # margin. 25 leaves the outer bound in place — a wedged shard still dies — | ||
| # while making a completed shard the normal outcome. The crash-retry below can | ||
| # double a shard's work, and this ceiling has to cover that second attempt too. | ||
| timeout-minutes: 25 | ||
|
Comment on lines
+556
to
+565
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Update the timeout comments to match the configuration: the Windows shard matrix matches Linux, but Windows intentionally uses a 25-minute timeout while Linux remains at 15 minutes. Apply the same clarification to the corresponding assertion comment in 📍 Affects 2 files
🤖 Prompt for AI Agents |
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Bun crashes near the end of the first attempt, this 25-minute job limit still cancels the shard during its retry: the workflow reports normal shard completion at 14–15 minutes, while the Test step reruns the entire shard from the beginning. Size the limit for setup plus two full test attempts, rather than less than twice the observed single-attempt duration, so the promised Windows evidence is not truncated again.
AGENTS.md reference: .github/AGENTS.md:L18-L18
Useful? React with 👍 / 👎.