-
Notifications
You must be signed in to change notification settings - Fork 854
fix(responses): routed-destination sanitize + opaque-state recovery series (#2254 rebased) #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
093a0d0
fix(responses): keep compaction blobs on the backend that minted them
olddonkey 64cdb11
fix(responses): stop reshaping reasoning items that carry encrypted_c…
olddonkey 1ec7343
fix(responses): drop a null reasoning content channel before routed p…
olddonkey 9a55a79
fix(responses): decide native-blob relay by destination, not by forwa…
olddonkey 02464b3
docs(responses): stop asserting a disproven cause for the blob-preser…
olddonkey 7e98283
fix(responses): scope the null-content strip to routed destinations
olddonkey 8d360fa
fix(xai): restore Grok Responses tool compatibility
olddonkey b7e8546
fix(responses): address namespace review findings
olddonkey d3a13f6
fix(responses): close the remaining private-shape leaks on the routed…
olddonkey 9a2f3ef
fix(responses): drop reasoning blobs and output-only status across a …
olddonkey 2dbc6c3
fix(responses): make namespace dedup order-independent and restore cu…
olddonkey e4cbac8
fix(responses): compare the serving identity on rotation-safe dimensions
olddonkey 4fed4c2
Merge branch 'fix/compaction-blob-provenance' into integration/grok-r…
olddonkey 61f1c8d
Merge branch 'fix/xai-reasoning-replay-integrity' into integration/gr…
olddonkey fb8e8a9
Merge branch 'fix/reasoning-null-content-channel' into integration/gr…
olddonkey 21919e2
Merge branch 'fix/cross-backend-reasoning-replay' into integration/gr…
olddonkey 4b3b39b
fix(responses): recover when an upstream rejects foreign opaque state
olddonkey 32a803c
fix(responses): compare serving identity for compaction blobs too
olddonkey 7722d06
Merge branch 'fix/blob-provenance-recovery' into integration/grok-res…
olddonkey 4005418
fix(responses): strip output-only reasoning status unconditionally
olddonkey 28fceec
refactor(responses): converge the two opaque-blob recovery call sites
olddonkey e0c8912
test(responses): pin that the first send already drops reasoning status
olddonkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a user-configurable provider option required for a relay to retain native compaction blobs; without it, the new default degrades those blobs to an opaque note. A repository-wide search finds
decodesNativeCompactionBlobsonly in runtime types/configuration and the internalstructure/note, with nodocs-site/documentation, so operators cannot discover how to preserve compaction context for a compatible relay. Add the option and its security/compatibility implications to the provider configuration documentation.AGENTS.md reference: AGENTS.md:L279-L280
Useful? React with 👍 / 👎.