Skip to content

test(xai): declare the web-search field capability in the raw streaming config #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Aug 21, 2026
+5 −2
Merged

test(xai): declare the web-search field capability in the raw streaming config #2263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/server-xai-responses-streaming.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,11 @@ function config(): OcxConfig {
baseUrl: "https://api.x.ai/v1",
authMode: "oauth",
models: ["grok-4.6"],
modelAdapters: { "grok-4.6": "openai-responses" },
modelSupportsServiceTier: { "grok-4.6": false },
modelAdapters: { "grok-4.6": "openai-responses" },
modelSupportsServiceTier: { "grok-4.6": false },
// Raw test config bypasses registry enrichment; production xai providers get
// this denial from the registry entry (see derive.ts enrichProviderFromRegistry).
supportsOpenAiWebSearchToolFields: false,

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Exercise registry enrichment instead of hard-coding the capability

When an xAI configuration is created by the normal provider/OAuth seed or predates this field, it does not contain supportsOpenAiWebSearchToolFields: providerConfigSeed deliberately omits registry-only metadata, while the request path uses routedProviderConfig, which currently does not backfill this capability or call enrichProviderFromRegistry. Setting the value directly in this fixture therefore makes the test pass without exercising production behavior and masks external_web_access being forwarded to xAI, where it causes a 400 response. Leave the fixture field unset and add the missing request-time registry backfill in routedProviderConfig, retaining this assertion as the focused regression test.

AGENTS.md reference: AGENTS.md:L276-L278

Useful? React with 👍 / 👎.

},
},
} as OcxConfig;
Expand Down
Loading