Bump LDK dependency#971
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
| self.logger, | ||
| "Onion message intercepted, but no onion message mailbox available" | ||
| ); | ||
| log_trace!(self.logger, "Onion message intercepted for unknown SCID"); |
There was a problem hiding this comment.
Shouldn't this be an error because the onion messenger is now created with intercept_for_unknown_scids set to false?
There was a problem hiding this comment.
Hmm, not sure, that seems overly strict? I.e., seems asserting that only intercepted events are emitted should be part part of LDK's test coverage, not part of LDK Node's production code?
There was a problem hiding this comment.
I mean just logging it as error, not necessarily returning an error.
There was a problem hiding this comment.
Okay, fine by me if you prefer. Amend the commit.
There was a problem hiding this comment.
Was just asking because it seemed that this branch is never expected to be hit.
Update LDK to revision 506cb91f2e0fb87906188b79777bcf42595d3623 from the 0.3 branch, and adapt onion-message interception to the new event and messenger APIs so the crate compiles. Co-Authored-By: HAL 9000
3 participants
Update LDK to revision 506cb91f2e0fb87906188b79777bcf42595d3623 from the 0.3 branch, and adapt onion-message interception to the new event and messenger APIs so the crate compiles.