Require ChannelClosed::counterparty_node_id#973
Open
tnull wants to merge 1 commit into
Open
Conversation
Require ChannelClosed events to carry the counterparty node id. This removes a legacy missing value that callers could no longer handle. Persisted v0.1 queues with missing ids now fail to read. Newer optional encodings with the id still read correctly. Co-Authored-By: HAL 9000
|
I've assigned @wpaulino as a reviewer! |
tnull
changed the title
ChannelClosed::counterparty_node_id
benthecarman
approved these changes
Jul 8, 2026
benthecarman
left a comment
benthecarman
left a comment
Contributor
There was a problem hiding this comment.
test is kinda overkill but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #895.
Require
ChannelClosedevents to carry the counterparty node id. This removes a legacy missing value that callers could no longer handle. Persisted v0.1 queues with missing ids now fail to read. Newer optional encodings with the id still read correctly.