Remove test-helper warnings#974
Open
benthecarman wants to merge 1 commit into
Open
Conversation
The shared integration-test helpers are macros used by different test binaries in different combinations. Export them as macros instead of reexporting private macro definitions from common, so targets that use only a subset no longer emit unused helper warnings. AI-Tool: OpenAI Codex
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Jul 9, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Sir, this is broken right now.
Also not a big fan of using macro_export here. It might make more sense to cfg-gate the respective methods so they are only exported when really needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the annoying unused warnings in tests
The shared integration-test helpers are macros used by different test binaries in different combinations. Export them as macros instead of reexporting private macro definitions from common, so targets that use only a subset no longer emit unused helper warnings.