version: bump to v0.1.37-beta - #99
Merged
Merged
Conversation
Release the Vault KV v2 support added by the parent PR under a distinct lndinit version. This lets the existing Docker release workflow build a Vault-capable image on the official LND v0.21.2-beta base without a special image suffix or manual build.
Member
Author
|
/gateway review |
![lightninglabs-gateway[bot]](https://avatars.githubusercontent.com/in/3635431?s=60&v=4){kind=small}
|
🤖 gateway audit metadata for this PR — auto-generated, please don't edit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Production runs the Vault KV v2 support from #92, but that code has no release tag. The current
v0.1.36-betarelease predates Vault support. This prevents the normal Docker release workflow from building a Vault-capable image on a newer LND base.Change
Bump lndinit to
v0.1.37-betaafter #92.Once this PR and #92 are on
main, the normal release tags can publish:The Docker workflow will then check out the Vault-capable
v0.1.37-betasource and use the officiallightninglabs/lnd:v0.21.2-betabase. No special-vaultbase image or manual build is needed.Scope
Test
go test ./...lightninglabs/lnd:v0.21.2-beta.v0.21.2-beta.