Add round - #409
Merged
Merged
Add round#409
round#409Conversation
Shnatsel
reviewed
Sep 30, 2026
Contributor
|
Looks good. Thank you! |
Shnatsel
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #355
This implements
roundfor all floating-point types to matchstd::simd.On ARM, it gets lowered to the
vrndaqfamily of instructions. On x86 and WASM it's emulated usingtrunc. The fallback uses scalarf<N>::roundas usual. Because of the fallback, we now also depend onlibm'sround{,f}functions.Notes on the emulation:
copysign(a, b)might not be perfectly optimal. On x86 and WASM, it's implemented using bitwise masking. Part of that is setting the sign bit ofato 0. The emulation uses a positive constant so that part is unnecessary. I'm not sure if LLVM can optimize it away.Update: LLVM successfully optimizes
copysignto useVPTERNLOGwith AVX512. So emulation is optimal with AVX512.