Repository navigation
Conversation
LaurenzV
added this pull request to stack #1979
October 5, 2026 12:51
laurenz-canva
force-pushed
the
laurenz/optional-blurred-rounded-rect
branch
2 times, most recently
from
October 5, 2026 13:28
d02bf8e to
ee0b31c
Compare
LaurenzV
force-pushed
the
laurenz/optional-blurred-rounded-rect
branch
from
October 5, 2026 13:53
ee0b31c to
48aa01b
Compare
laurenz-canva
force-pushed
the
laurenz/optional-blurred-rounded-rect
branch
from
October 5, 2026 14:05
48aa01b to
e5d0b12
Compare
laurenz-canva
force-pushed
the
laurenz/optional-blurred-rounded-rect
branch
from
October 5, 2026 14:35
e5d0b12 to
a4f4160
Compare
LaurenzV
commented
Oct 5, 2026
Comment on lines
+30
to
+32
| "blurred_rounded_rect", | ||
| "image_bicubic", | ||
| "gradient_sweep", |
Collaborator
Author
There was a problem hiding this comment.
Bit annoying having to redefine this everywhere. 😅 Not sure if we should figure out something else.
| # VELLO_SKIP_LFS_SNAPSHOTS: all | ||
|
|
||
| - name: run shader compilation tests | ||
| if: matrix.os == 'ubuntu-latest' |
Collaborator
Author
There was a problem hiding this comment.
Running this on Ubuntu on purpose instead of MacOS, as MacOS runs the whole workspace with all-feature, and that requires unnecessarily recompiling a lot of dependencies because the enabled features change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As our experiments have shown, complex shaders have a bad impact on performance as well as shader compilationt times on low-tier devices. This PR proposes a new method for allowing users to exclude certain features at compile-time, if they know they won't need it. In case they do still use it, we will panic at runtime.
This PR is best reviewed commit-by-commit.
render.weslmodule.vello_testsinto a custom crate, so that it can be reused by different tests. This is necessary because we want to be able to test the various configurations of enabled feature sets, which (as you will see) is easier to do by creating a new test crate, instead of modifyingvello_tests. Extracting this part of the code allows us to reuse the snapshot logic between the two.