Support account-level exclusions from named-blob cleanup - #3290
Merged
zichengl merged 1 commit intoAug 20, 2026
Conversation
Adds frontend.named.blob.cleanup.excluded.accounts alongside the existing excluded.containers list. An entry is an accountName; every container under a listed account is skipped. Kept as a separate property (rather than overloading the containers list with slash-less entries) so a missing "/containerName" can never silently widen a container exclusion into a whole-account one. Runner checks the account-level set first, then the container-level set; the unresolvable-account fail-open behavior is unchanged. Same trim/parse rules as the container list. Adds FrontendConfigTest + runner test coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3290 +/- ##
=============================================
- Coverage 64.24% 50.81% -13.43%
+ Complexity 10398 8704 -1694
=============================================
Files 840 938 +98
Lines 71755 80505 +8750
Branches 8611 9691 +1080
=============================================
- Hits 46099 40912 -5187
- Misses 23004 36205 +13201
- Partials 2652 3388 +736 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SophieGuo410
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an account-level exclusion to the named-blob stale-data cleanup runner, complementing the container-level exclusion added in #3286.
A new config property
frontend.named.blob.cleanup.excluded.accountstakes a comma-separated list ofaccountNameentries. Every container under a listed account is skipped by the cleanup runner, so its superseded (stale) named-blob versions are retained rather than deleted — useful for exempting an entire account without enumerating each of its containers.Design
...excluded.containerswith slash-less entries. Keeping them distinct means a missing"/containerName"(a typo) can never silently widen a single-container exclusion into a whole-account one.Testing
FrontendConfigTest: parsing/trimming of the new accounts list.NamedBlobsCleanupRunnerTest: an account-level exclusion skips every container under that account while a container in another account is still cleaned.