Log the cause when the named-blob cleaner skip-ahead lookup fails - #3292
Merged
zichengl merged 1 commit intoAug 21, 2026
Merged
Conversation
Addresses review feedback on linkedin#3291: the getFirstBlobName().get(timeout) call that finds the next blob name to skip to could fail (e.g. a query timeout) without any log identifying what happened. Wrap it and log the specific cause (TimeoutException / ExecutionException) at WARN before deferring the container to the next scheduled run. InterruptedException still propagates for clean shutdown handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3292 +/- ##
=============================================
- Coverage 64.24% 50.77% -13.48%
+ Complexity 10398 8696 -1702
=============================================
Files 840 938 +98
Lines 71755 80552 +8797
Branches 8611 9699 +1088
=============================================
- Hits 46099 40899 -5200
- Misses 23004 36260 +13256
- Partials 2652 3393 +741 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SophieGuo410
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3291 addressing review feedback: when the skip-ahead lookup (
getFirstBlobName().get(timeout)) that finds the next blob name to jump the cursor to fails, there was no log identifying what happened.Now the call is wrapped so a
TimeoutException/ExecutionExceptionis logged at WARN with the specific cause (and the container + cursor) before the container is deferred to the next scheduled run.InterruptedExceptionstill propagates so cleanup shutdown is handled cleanly.No behavior change beyond the added log and the explicit defer path.