Align repair test assertions with TtlUpdate partition query - #3295
Open
Hashim1999164 wants to merge 1 commit into
Open
Align repair test assertions with TtlUpdate partition query#3295Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
getPartitionsNeedRepair only lists partitions with foreign TtlUpdateRequest rows, while getRepairRequestsExcludingHost also returns DeleteRequest rows. Assert membership only when a foreign TTL update is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testPutGetDeleteSequence asserted that any partition with foreign repair rows must appear in getPartitionsNeedRepair. That query only returns partitions that hold foreign TtlUpdateRequest rows, while getRepairRequestsExcludingHost also returns DeleteRequest rows. Random layouts with delete only rows then failed the assertion intermittently.
The test now asserts partition membership only when a foreign TtlUpdateRequest is present. Delete only partitions still remove and verify records, but they no longer require a shrinking partitionsNeedRepair set.
Fixes #3288
Test plan