TPT-4462: Add integration tests for RDMA interfaces#713
Open
mawilk90 wants to merge 8 commits into
Open
Conversation
…ts-for-rdma-interfaces
mawilk90
changed the title
mawilk90
requested review from
lgarber-akamai and
psnoch-akamai
and removed request for
a team,
lgarber-akamai and
psnoch-akamai
Contributor
There was a problem hiding this comment.
Pull request overview
Adds integration coverage for RDMA VPC/Subnet behavior, ensuring vpc_type is surfaced correctly and RDMA resources behave as expected (notably around IPv6 behavior) in DevCloud.
Changes:
- Extend existing VPC/Subnet integration assertions to validate
vpc_type == "regular". - Add new RDMA-focused integration tests for loading and filtering RDMA VPCs and for creating/loading RDMA subnets.
- Introduce a session-scoped
create_vpc_with_rdma_typefixture to provision RDMA VPCs for tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/integration/models/vpc/test_vpc.py | Adds assertions for regular VPCs/subnets and introduces RDMA VPC/Subnet integration tests. |
| test/integration/conftest.py | Adds a session-scoped fixture to create/delete an RDMA VPC for integration tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+157
to
+159
| vpc = test_linode_client.vpcs(VPC.vpc_type == "rdma")[-1] | ||
| assert vpc.id == vpc_rdma.id | ||
| assert vpc.vpc_type == vpc_rdma.vpc_type |
| ) | ||
|
|
||
| # clean-up after test | ||
| request.addfinalizer(subnet_rdma.delete) |
Member
There was a problem hiding this comment.
Can you put the create/cleanup into a fixture just like how test Linode is handled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Created integration tests for functionality of RDMA interfaces
Note:
✔️ How to Test
make test-int TEST_ARGS="-k test_get_vpc_with_rdma_type"make test-int TEST_ARGS="-k test_get_vpc"make test-int TEST_ARGS="-k test_get_subnet_with_rdma_type"make test-int TEST_ARGS="-k test_get_subnet"