Update Python support to 3.10+ - #198
Conversation
|
Could you please send some of the clean up work as separate PRs? For example, I see Python 2 removals in the "Update Python support to 3.10+" commit. Also, PR checks have not run on this PR. I'm not sure if a change here broken them or if there's an existing issue. |
Removes nose as test runner, adds pytest instead.
e4b25f2 to
1916ad0
Compare
str.format() calls replaced with f-strings.
socket.timeout is an alias of TimeoutError since Python 3.10.
In Python 2, IOError/OSError could be raised as a tuple (errno, message).
1916ad0 to
04c90bb
Compare
|
Hi @timgraham 👋 I think I've extracted out the modernizations from that commit. Though I disagree with you about splitting it up into multiple PRs. When the maintainer comes around, they can decide if they want to split things up or merge them all in one go. Hard to know what they'll want right now. I'm also happy to have someone else cherry-pick the commits or redo things. I was just trying to help things along. As for why the tests aren't running, it's because the action is triggered on |
|
I have merge permissions on this repo. I don't see why tests shouldn't run on PRs, so I have proposed it in #199. |
Sorry for the duplicate PR. I dropped the other change around setting a specific encoding as it seemed silly on re-review.