Display error/reason to user, if a transport had to be restarted - #231
Open
msirringhaus wants to merge 3 commits into
Open
msirringhaus wants to merge 3 commits into
msirringhaus wants to merge 3 commits into
Conversation
msirringhaus
force-pushed
the
cancellation_part4
branch
from
September 29, 2026 11:50
b2209ab to
852e47b
Compare
iinuwa
reviewed
Sep 29, 2026
iinuwa
left a comment
iinuwa
left a comment
Member
There was a problem hiding this comment.
haven't run this yet, but a couple of questions
| } else { | ||
| // Pre-active: the QR was never consumed or the BLE channel | ||
| // failed before the phone responded. Reissue silently. | ||
| tracing::debug!(?err, "Hybrid pre-active error, reissuing QR silently"); |
Member
There was a problem hiding this comment.
I'm reading this on the train, so just wanted to double-check: can this get us in a restart loop? Is there a point where we eventually stop retrying a transport (without failing the ceremony)?
| /// as invalid by `TryFrom`. | ||
| #[repr(u8)] | ||
| #[derive(Debug, Clone, Copy, PartialEq, Eq)] | ||
| pub enum TransportRestartReason { |
Member
There was a problem hiding this comment.
We're currently using PascalCase strings to communicate enums everywhere else in the API. I find that easier to read in D-Bus output while debugging, and the extra 10 or so bytes in the message doesn't hurt.
Do you have opinions either way? If not, I'd recommend to make this a string for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Based on #230 , and needs to be rebased if/when this lands.
Only send events, if the device was actively used by the user (Hybrid: QR scanned, USB: initial touch done, etc.).
Extended the Restarting-events introduced in #230 with an error reason. Display it at the bottom of the start page. Removed those error codes that trigger restarts from the terminal error code list.
Last commit updates the lang-files.