Skip to content

daemon: Cancel request when the UI fails to launch - #240

Merged
iinuwa merged 1 commit into
linux-credentials:mainfrom
LucFauvel:fix/cancel-request-on-ui-launch-failure
Sep 27, 2026
Merged

iinuwa merged 1 commit into
linux-credentials:mainfrom
LucFauvel:fix/cancel-request-on-ui-launch-failure

Conversation

@LucFauvel

Copy link
Copy Markdown
Contributor

When launching the UI failed, the flow controller returned an error without cancelling the request it had initialized. The request context was never cleared, so every subsequent request was rejected as "Already a request in progress" until the daemon was restarted.

@iinuwa iinuwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This doesn't conflict with the other PRs, so this is not blocked by the other reviews.

just needs a CHANGELOG entry and switch the commit message to daemon: instead of fix:.

@LucFauvel LucFauvel changed the title fix: Cancel request when the UI fails to launch daemon: Cancel request when the UI fails to launch Sep 27, 2026
@LucFauvel
LucFauvel force-pushed the fix/cancel-request-on-ui-launch-failure branch from bcb90a4 to 7f54b99 Compare September 27, 2026 14:01
When launching the UI failed, the flow controller returned an error
without cancelling the request it had initialized. The request context
was never cleared, so every subsequent request was rejected as "Already
a request in progress" until the daemon was restarted.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@LucFauvel
LucFauvel force-pushed the fix/cancel-request-on-ui-launch-failure branch from 7f54b99 to 947f036 Compare September 27, 2026 14:04

@iinuwa iinuwa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iinuwa
iinuwa merged commit 3e5e0a3 into linux-credentials:main Sep 27, 2026
1 check passed
@LucFauvel
LucFauvel deleted the fix/cancel-request-on-ui-launch-failure branch September 27, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants