refactor: create libwebauthn-pxp - #311
Open
michaelbeaumont wants to merge 3 commits into
Open
michaelbeaumont wants to merge 3 commits into
michaelbeaumont wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was pretty aggressive with the renaming but "caBLE" is now two generations back, it's getting hard to find references to it in any specs so it should go, IMO.
I've used the new
libwebauthn-pxpcrate alone for non-CTAP purposes and it works.Fixes #307
One thing that's missing as described in the spec is technically:
But of course this is a breaking change. Maybe we need a toggle for framing? Otherwise everything should "just work".