fix: decode nested msgspec rename fields - #680
Merged
Merged
Conversation
cofin
marked this pull request as ready for review
August 6, 2026 16:15
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
+ Coverage 77.32% 77.38% +0.05%
==========================================
Files 476 476
Lines 68107 68163 +56
Branches 9363 9376 +13
==========================================
+ Hits 52665 52746 +81
- Misses 12033 12035 +2
+ Partials 3409 3382 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #679
Summary
Root cause
The conversion path inferred one rename convention from the outer Struct and recursively applied it to every nested dictionary. Single-word outer fields did not reveal the configured convention, while mixed nested conventions and arbitrary dictionary payloads could not be represented safely by one global transform.