feat(fishaudio): enable quality-guard on all TTS requests - #2237
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
feat(fishaudio): enable quality-guard on all TTS requests#2237rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 0149e78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports livekit/agents#6734.
Adds Fish Audio quality guard to the shared TTS request payload, enabling the server-side reliability feature for both HTTP and WebSocket synthesis without exposing a configuration option.
Source diff coverage
livekit-plugins/livekit-plugins-fishaudio/livekit/plugins/fishaudio/tts.py: Adapted toplugins/fishaudio/src/tts.ts. Addedfeatures: ['quality-guard']to the shared TypeScript request builder used by/v1/ttsand/v1/tts/live.tests/test_plugin_fishaudio_tts.py: Adapted toplugins/fishaudio/src/tts.test.ts. Ported the quality-guard assertion through the target repository's existing public-pathcaptureStartRequestharness becausebuildTtsRequestis module-private.Verification
pnpm buildpnpm lintpnpm format:checkpnpm test plugins/fishaudio -t "always enables quality guard"pnpm test plugins/fishaudio: 25 passed, 1 skipped, 1 unrelated existing failure atplugins/fishaudio/src/tts.test.ts:739(marks the terminal frame final before ending the streamexpects the final frame flag to be true). The failure reproduces consistently and is unrelated to request payload construction.Ported from livekit/agents#6734
Original PR description
Adds
features: ["quality-guard"]to every Fish Audio TTS request body, on both the HTTP (/v1/tts) and WebSocket (/v1/tts/live) paths.Quality guard is a server-side reliability feature that increases the stability of generations by catching errors and automatically retrying — built for our enterprise users. It has no drawback, so it's enabled always by default rather than exposed as an option.