fix(agents): prevent inference STT frame retention - #2240
Open
swayamg20 wants to merge 1 commit into
Open
Conversation
Replace the long-lived abort race in inference STT send and VAD loops with per-iteration cancellation that removes listeners after either side settles. Cover listener cleanup, cancellation, late rejection handling, and garbage collection of consumed inputs.
🦋 Changeset detectedLatest commit: 3cc2e7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2053
Validation
pnpm exec vitest run agents/src/inference/stt.test.ts --execArgv=--expose-gc— 71 passed, 1 credentialed integration test skippedpnpm exec vitest run agents/src— 115 files passed; 1,588 tests passed, 6 skippedpnpm build— 40 packages built successfullypnpm lint— passed with 145 existing warnings outside the changed filespnpm exec eslint -f unix agents/src/inference/stt.ts agents/src/inference/stt.test.ts— cleanpnpm format:checkpnpm throws:checkpnpm typecheck