fix: cancel pending onTrack callbacks when subscription fails

[lukasIO]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: f9f3eba

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
livekit-client	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/livekit-client.esm.mjs	104.79 KB (+0.1% 🔺)
dist/livekit-client.umd.js	113.78 KB (+0.07% 🔺)

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[1egoman]

I think I get the general idea and it makes sense, I'll let @boks1971 provide the actual review unless I am tagged explicitly otherwise.

[boks1971]

lgtm! One comment on track SID.

I do not understand the test though. I just cannot wrap my head around what is definition what is implementation :-)

[lukasIO]

I do not understand the test though. I just cannot wrap my head around what is definition what is implementation :-)

fair point. It's quite contrived due to synthesising a lot of state for this specific case.
The only goal of that test is to ensure that the onTrackAdded isn't invoked if we receive a subscription failure before the room is completely connected.
I threw out a bunch of the synthetisation and let the test be driven by the media track added event on the engine now.