Fix race in rtp.Session. - #81
Open
alexfish8 wants to merge 3 commits into
Open
Conversation
alexfish8
force-pushed
the
afish/fix-race
branch
from
August 22, 2026 00:12
31abfd8 to
69e6af7
Compare
alexfish8
marked this pull request as ready for review
August 22, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a few race/race-like conditions in the current implementation of
rtp.readStream:rtp.readStream, it's possible for the packets to be read out of order, e.g.:ReadRTPand it lends its buffer toreadStream. the reader then parks itself on thedirectselect statement.c.recvis selected, or packet B ifc.copiedis selected. If packet A is received, then packet B is dropped when the defer statement is run (that nils out the lent buffer and header. If packet B is received, then there's an out-of-order receive.This PR fixes the issue by ensuring a few things:
a. we write a packet to the stream
b. we check to see if the reader should lend its buffer or not.
Also, add a test.