Add the ability of using prefixes in pubsub channel names - #121
Open
karolyi wants to merge 1 commit into
Open
Conversation
Multiple psrpc deployments sharing one redis instance collide on pubsub channel names (redis DB index only scopes the keyspace, not PUBLISH/SUBSCRIBE). WithChannelPrefix lets callers namespace every channel the redis bus uses. Also widens TestRPC's fixed RPC-readiness sleeps to reduce unrelated CI flakiness (a fan-out request occasionally firing before all 3 servers finished registering).
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
the idea here is that I'm using FreeBSD where I have one Valkey instance that software uses. This module wasn't able to use prefixes for channels, which can lead to collisions, given I'd have more livekit deployments.
I'm already making changes to livekit itself to feature the prefix option, please merge this and update its dependency when able.
Next up I'll make a PR for livekit itself.