Remove struct field inboundCall.audioOut and mirror existing transfer workflow.

[alexfish8]

Addressing Denys' comment on the refactor PR.

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

🟡 Dial-tone sink closed before its writer goroutine stops

On a successful transfer, deferred cleanup closes oldRoomAudioOut before the deferred rcancel() runs, because defers execute LIFO and rcancel is registered first. The tones.Play goroutine keeps writing samples to that writer until rctx is cancelled, so it writes to the writer during and after its close.

Prompt for agents

In inboundCall.transferCall (pkg/sip/inbound.go around lines 1737-1762), the dial-tone goroutine started with tones.Play(rctx, oldRoomAudioOut, ...) keeps writing audio samples to oldRoomAudioOut until rctx is cancelled. However, the deferred cleanup that calls oldRoomAudioOut.Close() is registered after 'defer rcancel()', so due to LIFO defer ordering the Close runs before rcancel() cancels the context. This means on the success path the writer is closed while the tones.Play goroutine may still be writing to it (write-after-close race). Ensure the tone goroutine is stopped (rctx cancelled) and ideally has finished before closing oldRoomAudioOut, e.g. by cancelling and waiting for the goroutine (a done channel or WaitGroup) prior to closing, or by registering the close defer so it runs strictly after the goroutine has exited.

---

Was this helpful? React with 👍 or 👎 to provide feedback.