Fixed numpy version - #1137
Conversation
📝 WalkthroughWalkthroughThe change updates local ignore rules, package version constraints, and GitHub Actions workflow triggers. Docker builds now select platform and push behavior based on the triggering event. ChangesRepository configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Around line 27-35: Restore SciPy in the [project.dependencies] list because
plotting modules quantile_probability.py and predictive.py import scipy.stats at
runtime. Add a compatible scipy version constraint alongside the existing
numerical dependencies, rather than removing the dependency while those imports
remain.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dec3f9ec-bf63-4d32-ab13-cb0816dfae87
📒 Files selected for processing (3)
.codegraph/.gitignore.gitignorepyproject.toml
when related files change
|
I've closed #1145 in favor of this one. While verifying the overlap I dug into the resolution failure in depth — three findings that are worth folding in here, in decreasing order of importance. 1. This PR deletes
|
AlexanderFengler
left a comment
There was a problem hiding this comment.
lgtm let's merge this and drop my version of this.
scipy is imported directly by shipped source in hssm.plotting (gaussian_kde, chi2) but reaches installs only transitively via pymc after #1137 dropped the explicit entry. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
numbastill only supportsnumpy>=2.4.0, <2.5.0. However, dependency version resolving in CI can install numpy >= 2.5, which causesnumbato break, because its source code still uses deprecated numpy functions, which are removed in numpy 2.5. This PR fixes this issueThis PR also updates the devcontainer and docker build workflows, so that they only run on merge to main when relevant files have changed. No need to run them at every push
Summary by CodeRabbit