smite-scenarios: move executor tests to submodule - #227
Open
morehouse wants to merge 2 commits into
Open
Conversation
Most of executor.rs was tests, which we now move to their own file.
Program-building helpers are moved to tests/programs.rs. Mocks and other helper functions are moved to tests/harness.rs. The reason for this separation will become clearer in subsequent PRs where we will significantly refactor and extend the existing program-builders and helpers. Two decoder helpers and recv_channel_ready_executor are left in tests.rs and will be deleted entirely in subsequent PRs.
erickcestari
approved these changes
Sep 3, 2026
erickcestari
left a comment
erickcestari
left a comment
Contributor
There was a problem hiding this comment.
ACK 7aefe5a
This is beautiful
+1 -2,846
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure move, no code changes, easily reviewable with
git diff --color-moved --color-moved-ws=allow-indentation-change.This is the first in a series of PRs intended to simplify and improve the readability of the executor tests.