input: preserve CRLF cursor boundaries and document shortcuts - #2986
Merged
Conversation
kossoy
marked this pull request as ready for review
September 6, 2026 12:30
Member
|
Thanks |
feigeCode
pushed a commit
to feigeCode/gpui-component
that referenced
this pull request
Sep 7, 2026
…idge#2986) End can place a text-input cursor between CR and LF; subsequent typing splits the newline. Ctrl+Home/End also lacked non-macOS document bindings. Clip cursor and selection movement outside CRLF pairs, including the new multi-cursor movement/selection paths. Left/Right cross CRLF as one newline; a standalone CR remains an ordinary character. The rope and byte/UTF-16 APIs are unchanged. Add standard document navigation/selection bindings and a focused regression. Validation on this branch (43c733d), adapted to the multi-cursor implementation in cbdf5ba: - Linux and Windows full workspace test jobs pass; the Linux log confirms `textarea_cursor_treats_crlf_as_one_newline` passes among 838 base tests. - macOS lint, workspace tests and component doc-test step pass. - GPUI Shell Core, Component Shell, all three Standard Runtime jobs and documentation build pass. - Changed Rust files pass rustfmt checking locally. The pinned-version counterpart additionally passed native GPUI key-dispatch tests for LF/BOM/CRLF/mixed input, exact source-write payloads and actual muninn Linux Ctrl+End typing/save plus Ctrl+Home/End/Right/Left save checks in Tessera. Canonical BOM and all eight original CRLF pairs were retained. [CI run](https://github.com/longbridge/gpui-kit/actions/runs/34032397004)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
End can place a text-input cursor between CR and LF; subsequent typing splits the newline. Ctrl+Home/End also lacked non-macOS document bindings.
Clip cursor and selection movement outside CRLF pairs, including the new multi-cursor movement/selection paths. Left/Right cross CRLF as one newline; a standalone CR remains an ordinary character. The rope and byte/UTF-16 APIs are unchanged. Add standard document navigation/selection bindings and a focused regression.
Validation on this branch (43c733d), adapted to the multi-cursor implementation in cbdf5ba:
textarea_cursor_treats_crlf_as_one_newlinepasses among 838 base tests.The pinned-version counterpart additionally passed native GPUI key-dispatch tests for LF/BOM/CRLF/mixed input, exact source-write payloads and actual muninn Linux Ctrl+End typing/save plus Ctrl+Home/End/Right/Left save checks in Tessera. Canonical BOM and all eight original CRLF pairs were retained.
CI run