Harden DoP playback transitions - #512
Merged
kode54 merged 1 commit intoJul 19, 2026
Merged
Conversation
Stop playback when queued output format preparation fails. Reset stale DoP seek and fader state when returning to PCM. Preallocate integer-output scratch space outside the render callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens DoP playback transitions and Core Audio output preparation.
Motivation
Failed output preparation or a DoP-to-PCM transition could leave stale DoP state active. This could cause PCM data to be handled as a DoP carrier, replace output with DoP silence, or leave playback in an inconsistent state.
The integer-output path could also resize its scratch buffer inside the Core Audio render callback, which is unsafe for real-time audio processing.
Test plan