fix(i18n): populate broken en.json locale fallback - #1228
Open
coopdogGGs wants to merge 1 commit into
Open
Conversation
The generic 'en' locale file contained the literal text 'en-US.json' instead of JSON, so it failed to parse and broke the locales_match_en_us_keys test. Populate it with the English strings (mirroring en-US) and document the intent in gui.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic
enlocale file (src/gui/locales/en.json) contained the literal texten-US.jsoninstead of JSON. On startup it is loaded viainclude_str!and parsed as JSON, so any user on the genericenlocale hit an invalid-JSON parse, and thelocales_match_en_us_keysunit test failed (en.json is invalid JSON: expected value at line 1 column 1).This populates
en.jsonwith the English strings (mirroringen-US.json) and adds a short comment ingui.rsdocumenting that theenfallback must stay in sync withen-US.json.Verification:
cargo test-> 361 passed, 0 failed (previously 1 failed).