Add opt-in floating nametags above named/categorized OSM elements - #1286
Open
MJRobillard wants to merge 1 commit into
Open
Add opt-in floating nametags above named/categorized OSM elements#1286MJRobillard wants to merge 1 commit into
MJRobillard wants to merge 1 commit into
Conversation
--nametags (Java only, off by default) floats a minecraft:text_display label above every element with a name (or synthesized address) and/or a recognized OSM category tag, independent of any other feature. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--nametagsflag (Java only, off by default) that floats aminecraft:text_displaylabel above every OSM element with a name (or a synthesized<housenumber> <street>address) and/or a recognized OSM category tag (amenity, shop, leisure, tourism, railway, highway, building, office, craft, landuse, natural, man_made).src/nametags.rsmodule — no changes to existing block/entity APIs, no interaction with any other feature.Test plan
cargo test --release --no-default-features nametags— 6 new unit tests pass (label collection, address fallback, boolean-tag skipping, way centroid, entity placement)cargo build --release --no-default-features— clean build, no new warningscargo fmt --check/cargo clippy— clean🤖 Generated with Claude Code