DM-55972: Switch test suite from direct vcrpy use to pytest-recording - #195
Open
mfisherlevine wants to merge 2 commits into
Open
DM-55972: Switch test suite from direct vcrpy use to pytest-recording#195mfisherlevine wants to merge 2 commits into
mfisherlevine wants to merge 2 commits into
Conversation
mfisherlevine
force-pushed
the
tickets/DM-55972
branch
from
August 27, 2026 21:17
2bbfac4 to
bc29ae0
Compare
Test classes are now marked with @pytest.mark.vcr and configured via tests/conftest.py, which keeps the existing flat cassette directory and bare-function-name cassette naming so no recordings need regenerating. vcrpy (which pytest-recording wraps) is retained only for setUpClass, which runs outside the per-test fixture the plugin uses, and for the setUp in test_ics, which is recorded separately from its tests and so nests its own cassette inside the plugin's. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pytest-vcr and pytest-recording are mutually exclusive, and the stack environment will move from the former to the latter at some point. Rather than having to land this branch at the exact moment that happens, conftest.py now detects which plugin is loaded and adapts to it: the record mode is read from --vcr-record or --record-mode as appropriate, and the cassette name is overridden via both vcr_cassette_name and default_cassette_name. This commit is purely additive and should be reverted once the environment has moved to pytest-recording. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mfisherlevine
force-pushed
the
tickets/DM-55972
branch
from
September 3, 2026 15:19
bc29ae0 to
a54a458
Compare
mypy-coverage report✅ All 803 definitions are fully annotated.
Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=======================================
Coverage 23.38% 23.38%
=======================================
Files 38 38
Lines 7077 7077
=======================================
Hits 1655 1655
Misses 5422 5422
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test classes are now marked with @pytest.mark.vcr and configured via tests/conftest.py, which keeps the existing flat cassette directory and bare-function-name cassette naming so no recordings need regenerating. vcrpy (which pytest-recording wraps) is retained only for setUpClass, which runs outside the per-test fixture the plugin uses.