Skip to content

DM-55738: Update PromptTemplate and QuickTemplate for incremental Rubin and DECam template development #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erinleighh merged 2 commits into from
Aug 15, 2026
Merged

DM-55738: Update PromptTemplate and QuickTemplate for incremental Rubin and DECam template development #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b9a48c
Update Prompt & QuickTemplate for incremental templates
erinleighh Aug 6, 2026
0d24a2f
Add DECam specfic configs to QuickTemplate
erinleighh Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bps/clustering/clustering_PromptTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ cluster:
make_tract_analysis_images:
pipetasks: makeWholeTractTemplateCoaddNImage,makeWholeTractTemplateCoaddImage
dimensions: tract,band
make_metrics:
pipetasks: analyzeCoaddDepthCore,coaddDepthMetricTract
dimensions: tract
15 changes: 12 additions & 3 deletions bps/clustering/clustering_QuickTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,17 @@ cluster:
pipetasks: consolidateVisitSummary
dimensions: visit
makeWarp:
pipetasks: makeWarp
dimensions: tract,patch,visit
pipetasks: makeDirectWarp,makePsfMatchedWarp
dimensions: patch,visit
selectAndAssemble:
pipetasks: selectGoodSeeingVisits,assembleCoadd
pipetasks: selectTemplateCoaddVisits,assembleTemplateCoadd
dimensions: band,tract,patch
make_analysis_images:
pipetasks: makeBinnedTemplateCoaddNImage,makeBinnedTemplateCoaddImage
dimensions: tract,band
make_tract_analysis_images:
pipetasks: makeWholeTractTemplateCoaddNImage,makeWholeTractTemplateCoaddImage
dimensions: tract,band
make_metrics:
pipetasks: analyzeCoaddDepthCore,coaddDepthMetricTract
dimensions: tract
6 changes: 6 additions & 0 deletions pipelines/DECam/QuickTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,9 @@ tasks:
config:
connections.outputExposure: post_isr_image
file: $AP_PIPE_DIR/config/DECam/runIsrWithCrosstalk.py
selectTemplateCoaddVisits:
class: lsst.pipe.tasks.selectImages.BestSeeingQuantileSelectVisitsTask
config:
maxPsfFwhm: 1.8
nVisitsMin: 8
qMax: 0.5
45 changes: 6 additions & 39 deletions pipelines/LSSTCam/PromptTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,57 +4,24 @@ description: The LSSTCam AP template building pipeline with preliminary_visit_im
instrument: lsst.obs.lsst.LsstCam

imports:
- location: $DRP_PIPE_DIR/pipelines/_ingredients/base-v2.yaml
include:
- consolidateVisitSummary
- location: $AP_PIPE_DIR/pipelines/_ingredients/QuickTemplate.yaml
exclude:
- isr
- calibrateImage
- selectTemplateCoaddVisits
- makeDirectWarp
- makePsfMatchedWarp
- assembleTemplateCoadd
- makeBinnedTemplateCoaddImage
- makeBinnedTemplateCoaddNImage
- makeWholeTractTemplateCoaddImage
- makeWholeTractTemplateCoaddNImage
- location: $ANALYSIS_TOOLS_DIR/pipelines/coaddDepthMetrics.yaml
include:
- analyzeCoaddDepthCore
- coaddDepthMetricTract

tasks:
consolidateVisitSummary:
class: lsst.pipe.tasks.postprocess.ConsolidateVisitSummaryTask
config:
full: True

@mrawls mrawls Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a comment for why this override is needed (because we're starting with preliminary_visit_images?)

makeDirectWarp:
class: lsst.drp.tasks.make_direct_warp.MakeDirectWarpTask
config:
connections.visit_summary: preliminary_visit_summary
useVisitSummaryPsf: False
selectTemplateCoaddVisits:
# Class changed from BestSeeingQuantileSelectVisitsTask due to different template
# expectations for incremental templates.
class: lsst.pipe.tasks.selectImages.BestSeeingSelectVisitsTask
Comment thread
erinleighh marked this conversation as resolved.
config:
connections.visitSummaries: preliminary_visit_summary
connections.goodVisits: template_coadd_visit_selection
maxPsfFwhm: 1.4
python: |
config.visitSummaryMinValues = {'effTimeZeroPointScale': 0.75}

subsets:
makeTemplate:
subset:
- selectTemplateCoaddVisits
- makeDirectWarp
- makePsfMatchedWarp
- assembleTemplateCoadd
description: >
Tasks to run to build template_coadds.
makeMetrics:
subset:
- makeBinnedTemplateCoaddImage
- makeBinnedTemplateCoaddNImage
- makeWholeTractTemplateCoaddImage
- makeWholeTractTemplateCoaddNImage
- analyzeCoaddDepthCore
- coaddDepthMetricTract
description: >
Metrics and plots to run on the template_coadds.
55 changes: 43 additions & 12 deletions pipelines/_ingredients/QuickTemplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,23 @@ imports:
- isr
- calibrateImage
- consolidateVisitSummary
- selectDeepCoaddVisits
- selectTemplateCoaddVisits
- makeDirectWarp
- makePsfMatchedWarp
- assembleTemplateCoadd
- makeTemplateCoaddInputSummaryTract
- makeTemplateCoaddInputSummary
- makeBinnedTemplateCoaddImage
- makeBinnedTemplateCoaddNImage
- makeWholeTractTemplateCoaddImage
- makeWholeTractTemplateCoaddNImage
Comment thread
erinleighh marked this conversation as resolved.
- aggregateTemplateCoaddMaskFractions
- makeAggregatedTemplateCoaddMaskFractionsTable
- aggregatedTemplateCoaddMaskFractionsWholeSkyPlot
- location: $ANALYSIS_TOOLS_DIR/pipelines/coaddDepthMetrics.yaml
include:
- analyzeCoaddDepthCore
- coaddDepthMetricTract

tasks:
calibrateImage:
Expand All @@ -25,35 +38,53 @@ tasks:
# take many 10s of seconds in crowded fields
do_remeasure_star_background: False
doMaskDiffractionSpikes: True
selectDeepCoaddVisits:
class: lsst.pipe.tasks.selectImages.BestSeeingSelectVisitsTask
config:
connections.visitSummaries: preliminary_visit_summary
makeDirectWarp:
class: lsst.drp.tasks.make_direct_warp.MakeDirectWarpTask
config:
connections.visit_summary: preliminary_visit_summary
useVisitSummaryPsf: False
selectTemplateCoaddVisits:
class: lsst.pipe.tasks.selectImages.BestSeeingQuantileSelectVisitsTask
config:
connections.visitSummaries: preliminary_visit_summary
assembleTemplateCoadd:
class: lsst.drp.tasks.assemble_coadd.CompareWarpAssembleCoaddTask
config:
connections.selectedVisits: deep_coadd_visit_selection
maxFractionEpochsHigh: 0.2
badMaskPlanes: ["NO_DATA", "BAD", "SAT", "EDGE", "SPIKE"]
prefilterArtifactsMaskPlanes: ["NO_DATA", "BAD", "SUSPECT", "SPIKE"]

subsets:
makeTemplate:
singleFrame:
subset:
- isr
- calibrateImage
description: >
Tasks to run to get preliminary visit images.
makeTemplate:
subset:
- consolidateVisitSummary
- selectDeepCoaddVisits
- selectTemplateCoaddVisits
- makeDirectWarp
- makePsfMatchedWarp
- assembleTemplateCoadd
description: >
Tasks to run to build good seeing coadds for use as templates.
makeMetrics:
subset:
- makeTemplateCoaddInputSummaryTract
- makeTemplateCoaddInputSummary
- makeBinnedTemplateCoaddImage
- makeBinnedTemplateCoaddNImage
- makeWholeTractTemplateCoaddImage
- makeWholeTractTemplateCoaddNImage
- aggregateTemplateCoaddMaskFractions
- makeAggregatedTemplateCoaddMaskFractionsTable
- aggregatedTemplateCoaddMaskFractionsWholeSkyPlot
- analyzeCoaddDepthCore
- coaddDepthMetricTract
description: >
Metrics and plots to run on the templates.

contracts:
# Inputs and outputs must match. For consistency, contracts are written in execution order:
Expand All @@ -66,11 +97,11 @@ contracts:
makeDirectWarp.connections.ConnectionsClass(config=makeDirectWarp).calexp_list.name
msg: "calibrateImage.exposure != makeWarp.calexp_list"
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
selectDeepCoaddVisits.connections.ConnectionsClass(config=selectDeepCoaddVisits).visitSummaries.name
msg: "consolidateVisitSummary.visitSummary != selectDeepCoaddVisits.visitSummaries"
selectTemplateCoaddVisits.connections.ConnectionsClass(config=selectTemplateCoaddVisits).visitSummaries.name
msg: "consolidateVisitSummary.visitSummary != selectTemplateCoaddVisits.visitSummaries"
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
makeDirectWarp.connections.ConnectionsClass(config=makeDirectWarp).visit_summary.name
msg: "consolidateVisitSummary.visitSummary != makeDirectWarp.visit_summary"
- contract: selectDeepCoaddVisits.connections.ConnectionsClass(config=selectDeepCoaddVisits).goodVisits.name ==
- contract: selectTemplateCoaddVisits.connections.ConnectionsClass(config=selectTemplateCoaddVisits).goodVisits.name ==
assembleTemplateCoadd.connections.ConnectionsClass(config=assembleTemplateCoadd).selectedVisits.name
msg: "selectDeepCoaddVisits.goodVisits != assembleTemplateCoadd.selectedVisits"
msg: "selectTemplateCoaddVisits.goodVisits != assembleTemplateCoadd.selectedVisits"
Loading